setup.exe (cinstall) bugfixes + minor new feature

Max Bowsher maxb@ukf.net
Sun Mar 3 10:01:00 GMT 2002


I've been working with the setup code, and have discovered some bugs in the
current (just updated) CVS version.

I'm posting a patch here for comments, whilst I join cygwin-patches, and
study the Contributing instructions.

The patch does the following:

BugFix: io_stream::mkpath_p(isadir, path) misuse
mkpath_p is supposed to take a path with either a file:// or a cygfile://
prefix, but it is fed a path with no prefix in some places. The patch adds a
file:// prefix where needed.
This was causing some directories not to be created, including the Cygwin
directory in the start menu.

BugFix: add backslash call to make_link, in desktop.cc
This was causing the start menu shortcut to be called
'Programs/Cygwin/Cygwin Bash Shell' instead of being in the correct
directory structure

Feature Addition: Use files /etc/setup/inhibit-{startmenu,desktop}-icon to
remeber user de-selection of the create icon checkboxes on the last page of
setup.

Max.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: currwork.patch
Type: application/octet-stream
Size: 2707 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin/attachments/20020303/e40aec4f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2688 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin/attachments/20020303/e40aec4f/attachment.bin>


More information about the Cygwin mailing list