cygwin_dll.h Inconsistency (a.k.a Problem #2 Building Cygwin PostgreSQL)

[Jason Tishler]

While building PostgreSQL 7.0.2 on a stock Cygwin 1.1.4, I noticed the
following inconsistency in cygwin/cygwin_dll.h:

// declaration
int WINAPI _cygwin_dll_entry (HANDLE h, DWORD reason, void *ptr);

// definition
int WINAPI _cygwin_dll_entry (HINSTANCE h, DWORD reason, void *ptr)
{
    ...
}

Unless NO_STRICT is defined (which prevents STRICT from automatically
being defined), HINSTANCE will not be a typedef for HANDLE:

// from winnt.h
#ifdef STRICT
#define DECLARE_HANDLE(n) typedef struct n##__{int i;}*n
#else
#define DECLARE_HANDLE(n) typedef HANDLE n
#endif

// from windef.h
DECLARE_HANDLE(HINSTANCE);

Shouldn't the declaration and definition of _cygwin_dll_entry use either
HANDLE or HINSTANCE consistently?

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corporation         Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com