windres and an icon in a dialog

[Mumit Khan]

On 10 Jan 2000, Sascha Ziemann wrote:

> I have defined the icon:
> 
> ABOUT1 ICON DISCARDABLE "icon5.ico"
> 
> And then I use it:
> 
> ABOUT_WINDOW DIALOG DISCARDABLE 32, 32, 180, 100
> STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION
> FONT 8, "MS Sans Serif"
> BEGIN
>   DEFPUSHBUTTON  "Ok", IDOK, 66, 80, 50, 14
>   ICON           "ABOUT1", IDC_STATIC, 7, 7, 32, 32, 0
>   CTEXT          "text one", IDC_STATIC, 40, 12, 100, 8
>   CTEXT          "text two", IDC_STATIC, 7, 52, 166, 8
> END
> 
> But it is missing in the dialog.  The strings and the button are there
> and windres does not report any errors.
> 

It looks like a bug in windres. Here's a fix that works for both windres
and MS RC. The bug seems to be the icon controls within dialogs don't
like being defined in terms of "id", but rather expect a "name" instead.

    about_icon ICON DISCARDABLE "icon5.ico"

    ABOUT_WINDOW DIALOG DISCARDABLE 32, 32, 180, 100
    STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION
    FONT 8, "MS Sans Serif"
    BEGIN
      DEFPUSHBUTTON  "Ok", IDOK, 66, 80, 50, 14
      ICON           "about_icon", IDC_STATIC, 7, 7, 32, 32, SS_ICON
      CTEXT          "text one", IDC_STATIC, 40, 12, 100, 8
      CTEXT          "text two", IDC_STATIC, 7, 52, 166, 8
    END

I'll fix this for the next release. Thanks for the bug report with a 
easy to work with testcase!

Regards,
Mumit



--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com