[PATCH v4.2] Cygwin: pipe: Switch pipe mode to blocking mode by defaut
Takashi Yano
takashi.yano@nifty.ne.jp
Sat Sep 21 21:15:38 GMT 2024
On Fri, 20 Sep 2024 23:09:17 +0900
Takashi Yano wrote:
> On Fri, 20 Sep 2024 22:24:14 +0900
> Takashi Yano wrote:
> > On Fri, 20 Sep 2024 18:23:35 +0900
> > Takashi Yano wrote:
> > > On Wed, 18 Sep 2024 10:03:13 -0400
> > > Ken Brown wrote:
> > > > One other thing that I missed in my first review. Is there a possible
> > > > race condition here? What if the pipe is empty now but another writer
> > > > fills the pipe before we try to write? Can that happen? If so, maybe
> > > > it's safer to leave the pipe non-blocking instead of restoring it to
> > > > blocking.
> > >
> > > Thanks!
> > > Shouldn't we add mutex guard for raw_write() as well as raw_read()?
> > >
> > > I think I have addressed all the points you have raised. Could you
> > > please check v5 patch?
> >
> > Bug in v5 has been fixed in v6.
>
> v7: Improve error handling in raw_write()
v8: Small bug fixes and trivial changes.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
More information about the Cygwin-patches
mailing list