[PATCH] Cygwin: pthread: Take note of schedparam in pthread_create

Jon Turney jon.turney@dronecode.org.uk
Thu Jul 13 13:14:14 GMT 2023


Take note of schedparam in any pthread_attr_t passed to pthread_create.

postcreate() (racily, after the thread is actually created), sets the
scheduling priority if it's inherited, but precreate() doesn't store any
scheduling priority explicitly set via a non-default attr to create, so
schedparam.sched_priority has the default value of 0.

(I think this is another long-standing bug exposed by 4b51e4c1.  Now we
don't lie about the actual thread priority, it's apparent it's not
really being set in this case.)

Fixes testcase priority2.
---
 winsup/cygwin/thread.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
index f614e01c4..afddf4282 100644
--- a/winsup/cygwin/thread.cc
+++ b/winsup/cygwin/thread.cc
@@ -457,6 +457,7 @@ pthread::precreate (pthread_attr *newattr)
       attr.joinable = newattr->joinable;
       attr.contentionscope = newattr->contentionscope;
       attr.inheritsched = newattr->inheritsched;
+      attr.schedparam = newattr->schedparam;
       attr.stackaddr = newattr->stackaddr;
       attr.stacksize = newattr->stacksize;
       attr.guardsize = newattr->guardsize;
-- 
2.39.0



More information about the Cygwin-patches mailing list