[PATCH] Cygwin: console: Correct the past fix for apps which open pty.

Takashi Yano takashi.yano@nifty.ne.jp
Sun Feb 27 03:47:58 GMT 2022


- The commit "Cygwin: console: Fix issues of apps which open pty."
  did not fix the second problem correctly. That commit looked to
  fix the issue, but the actual problem was that ctrl_c_handler()
  should be reregistered *AFTER* FreeConsole()/AttachConsole().
  This patch correct that.
---
 winsup/cygwin/fhandler_termios.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/fhandler_termios.cc b/winsup/cygwin/fhandler_termios.cc
index 568523390..767b28302 100644
--- a/winsup/cygwin/fhandler_termios.cc
+++ b/winsup/cygwin/fhandler_termios.cc
@@ -344,10 +344,10 @@ fhandler_termios::process_sigs (char c, tty* ttyp, fhandler_termios *fh)
 	      (myself->dwProcessId, false);
 	  if (resume_pid && fh && !fh->is_console ())
 	    {
-	      if (::cygheap->ctty && ::cygheap->ctty->is_console ())
-		init_console_handler (false);
 	      FreeConsole ();
 	      AttachConsole (p->dwProcessId);
+	      if (::cygheap->ctty && ::cygheap->ctty->is_console ())
+		init_console_handler (true);
 	    }
 	  if (fh && p == myself && being_debugged ())
 	    { /* Avoid deadlock in gdb on console. */
-- 
2.35.1



More information about the Cygwin-patches mailing list