[PATCH] Cygwin: pty: Rename input named pipes.
Corinna Vinschen
corinna-cygwin@cygwin.com
Mon Mar 22 11:49:20 GMT 2021
Hi Takashi,
On Mar 21 12:59, Takashi Yano via Cygwin-patches wrote:
> - Currently, the name of input pipe is "ptyNNNN-from-master" for
> cygwin process, and "ptyNNNN-to-slave" for non-cygwin process.
> These are not only inconsistent with output pipes but also very
> confusing.
> With this patch, these are renamed to "ptyNNNN-from-master-cyg"
> and "ptyNNNN-from-master" respectively.
> ---
> winsup/cygwin/fhandler_tty.cc | 2 +-
> winsup/cygwin/tty.cc | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Actually... wouldn't it make more sense to call the Cygwin pipe
pty%d-from-master / pty%d-to-slave
and the non-Cygwin one something like
pty%d-from-master-nat / pty%d-to-slave-nat
?
After all, Cygwin is the norm, and non-Cygwin is the exception.
On second thought, this would also make sense for thr fhandler methods,
i. e.
get_output_handle / get_output_handle_cyg
vs.
get_output_handle_nat / get_output_handle
Probably the fhandler stuff is too much renaming for this release,
but we should do this for the next one, I think.
Thanks,
Corinna
More information about the Cygwin-patches
mailing list