[PATCH] CYGWIN: Fix resolver debugging output

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Feb 1 19:02:15 GMT 2021


On Feb  1 15:46, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote:
> > Except, the value has no meaning for ipv6.
> 
> It'll print all 0's :-)  But:
> 
> minires does not make use of the _ext field.  It does use the conventional nsaddr_list (which is IPv4),
> but only if Windows native DNS API is not used: "osquery"(aka use_os)=0.
> 
> For debugging purposes, that is enough and very convenient (yet the output needed some tune-up, which I suggested in my patch).

Ok.

> But for practical purposes, only Windows API should be used in regular applications (which is the default, anyways, since
> /etc/resolv.conf is not routinely provided, so "osquery=1" implicitly).

Yeah, I think so, too.  Ideally we should have stripped out all code
providing non-Windows means (i. e., /etc/resolv.conf support) back when
this code was folded into Cygwin.  It just doesn't make sense, at least
not by default.

> I'm not sure if improvements to use _ext by the minires own code would be any beneficial.
> 
> Having said that, AAAA replies should be made understood by the minires-if-os shim code
> (and I can provide a patch for that, too).

That would be great!


Thanks,
Corinna


More information about the Cygwin-patches mailing list