fhandler_serial.cc: MARK and SPACE parity for serial port
Corinna Vinschen
corinna-cygwin@cygwin.com
Thu Jan 28 10:14:29 GMT 2021
Oh, btw...
On Jan 28 11:08, Corinna Vinschen via Cygwin-patches wrote:
> Hi Marek,
>
> thanks for the patch. [...]
> > index 17e8d83a3..933851c21 100644
> > --- a/winsup/cygwin/include/sys/termios.h
> > +++ b/winsup/cygwin/include/sys/termios.h
> > @@ -185,6 +185,7 @@ POSIX commands */
> > #define PARODD 0x00200
> > #define HUPCL 0x00400
> > #define CLOCAL 0x00800
> > +#define CMSPAR 0x40000000 /* Mark or space (stick) parity. */
Why did you choose such a big value here? Wouldn't it be nicer just to
follow up with
#define CMSPAR 0x10000
or am I missing something here?
Also, on second thought I think CMSPAR should follow CRTSCTS, a few
lines below, because of its numerical value higher than CRTSCTS.
Thanks,
Corinna
More information about the Cygwin-patches
mailing list