[PATCH] Cygwin: pty: Add workaround for ISO-2022 and ISCII in convert_mb_str().

[Corinna Vinschen]

On Sep 12 04:11, Takashi Yano via Cygwin-patches wrote:
> On Fri, 11 Sep 2020 20:57:06 +0200
> Corinna Vinschen wrote:
> > On Sep 12 03:37, Takashi Yano via Cygwin-patches wrote:
> > > On Sat, 12 Sep 2020 02:38:43 +0900
> > > Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com> wrote:
> > > > How about the patch attached?
> > > > I think this is safer than previous patch.
> > > 
> > > I have revised this patch to fit current git head, and submit
> > > to cygwin-patches@cygwin.com.
> > 
> > Thanks, but I didn't apply this one because it doesn't really make sense
> > to go to the extra effort to support outdated and incompatible codepages
> > we don't handle as Cygwin codeset at all.  IMHO it's not worth to call
> > another MBTWC just to check if a codepage supports the MB_ERR_INVALID_CHARS
> > flag.
> 
> I have checked which codepage does not support MB_ERR_INVALID_CHARS.
> The result is as follows.
> 
> 42
> 50220
> 50221
> 50222
> 50225
> 50227
> 50229
> 52936
> 57002
> 57003
> 57004
> 57005
> 57006
> 57007
> 57008
> 57009
> 57010
> 57011
> 65000

Yup, these are documented on MSDN:
https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-widechartomultibyte

> If all of these are not worth for everyone, I agree with you.

I think we can skip those.


Corinna