[PATCH] Cygwin: pty: Add workaround for ISO-2022 and ISCII in convert_mb_str().

Fri Sep 11 19:11:16 GMT 2020

On Fri, 11 Sep 2020 20:57:06 +0200
Corinna Vinschen wrote:
> On Sep 12 03:37, Takashi Yano via Cygwin-patches wrote:
> > On Sat, 12 Sep 2020 02:38:43 +0900
> > Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com> wrote:
> > > How about the patch attached?
> > > I think this is safer than previous patch.
> > 
> > I have revised this patch to fit current git head, and submit
> > to cygwin-patches@cygwin.com.
> 
> Thanks, but I didn't apply this one because it doesn't really make sense
> to go to the extra effort to support outdated and incompatible codepages
> we don't handle as Cygwin codeset at all.  IMHO it's not worth to call
> another MBTWC just to check if a codepage supports the MB_ERR_INVALID_CHARS
> flag.

I have checked which codepage does not support MB_ERR_INVALID_CHARS.
The result is as follows.

If all of these are not worth for everyone, I agree with you.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>