[PATCH 2/4] dlopen (pathfinder): try each basename per dir

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Sep 1 14:05:00 GMT 2016


On Aug 31 20:07, Michael Haubenwallner wrote:
> Rather than searching all search dirs per one basename,
> search for all basenames within per one search dir.
> 
> pathfinder.h (check_path_access): Interchange dir- and basename-loops.
> ---
>  winsup/cygwin/pathfinder.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/winsup/cygwin/pathfinder.h b/winsup/cygwin/pathfinder.h
> index bbba168..c306604 100644
> --- a/winsup/cygwin/pathfinder.h
> +++ b/winsup/cygwin/pathfinder.h
> @@ -182,12 +182,12 @@ public:
>  	     basenamelist::member const ** found_basename = NULL)
>    {
>      char const * critname = criterion.name ();
> -    for (basenamelist::iterator name = basenames_.begin ();
> -	 name != basenames_.end ();
> -	 ++name)
> -      for (searchdirlist::iterator dir(searchdirs_.begin ());
> -	   dir != searchdirs_.end ();
> -	   ++dir)
> +    for (searchdirlist::iterator dir(searchdirs_.begin ());
> +	 dir != searchdirs_.end ();
> +	 ++dir)
> +      for (basenamelist::iterator name = basenames_.begin ();
> +	   name != basenames_.end ();
> +	   ++name)
>  	if (criterion.test (dir, name))
>  	  {
>  	    debug_printf ("(%s), take %s%s", critname,
> -- 
> 2.7.3

This one's fine, of course.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160901/a9f86530/attachment.sig>


More information about the Cygwin-patches mailing list