[PATCH 04/11] Remove misleading indentation
Corinna Vinschen
corinna-cygwin@cygwin.com
Sun Mar 20 11:03:00 GMT 2016
On Mar 19 13:45, Peter Foley wrote:
> GCC 6.0+ warns on misleading indentation, so fix it.
>
> winsup/cygserver/ChangeLog
> * sysv_msg.cc (msgsnd): Fix misleading indentation.
> * sysv_msg.cc (msgrcv): Ditto.
> * sysv_sem.cc (semop): Ditto.
> winsup/cygwing/ChangeLog
> * syscalls.cc (getpriority): Fix misleading indentation.
I only applied the hunk affecting syscalls.cc for now.
The patches to sysv_msg.cc and sysv_sem.cc are not quite right, IMHO.
The GCC warning is rather a problem here. The indentation is correct
in terms of the original code. The only reason it's treated as incorrect
is the special handling added in the #ifdef __CYGWIN__ block. Changing
the indentation just to satisfy the special Cygwin case is not the way
to go.
Ohter than that, partially applied.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160320/61aaa9dc/attachment.sig>
More information about the Cygwin-patches
mailing list