[PATCH] workaround for sigproc_init

Christopher Faylor cgf-use-the-mailinglist-please@cygwin.com
Sat Jul 30 20:57:00 GMT 2011


On Fri, Jul 29, 2011 at 08:41:10PM +0900, jojelino wrote:
>As sigproc_init is called during dll initialization, wait_sig thread is 
>not created as soon as possible.(this is known in msdn createthread 
>reference. http://msdn.microsoft.com/en-us/library/ms682453(v=vs.85).aspx)
>And then wait_sig starts to wake up as sig_dispatch_pending enters 
>waitforsingleobject. then main thread stops for few ms. and it shows 
>poor performance.
>as a workaround, issue user apc call, let the os decide when to call them.
>And the result was quite good. patch,changelog modified are attached.
>Please review it.

The result is good but the patch isn't the way I chose to implement
this.  I appreciate the idea, though.  The performance improvement
is amazing.

Thanks for the patch/idea.

cgf

P.S.  I really do appreciate the effort that you put into this but, had
it been accepted, it would have required some reformatting since you
used a different indentation style from the rest of the code.  I hope
that you'll consider keeping your changes formatted like the surrounded
code.  It will make patch adoption easier.



More information about the Cygwin-patches mailing list