[1.7] bugs in faccessat

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Sep 25 08:11:00 GMT 2009


Hi Eric,

thanks for the patch.  Basically it looks ok, I have just two cosmetic
comments inline.

On Sep 24 21:35, Eric Blake wrote:
> diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc
> index 00a8c32..8c67fc9 100644
> --- a/winsup/cygwin/security.cc
> +++ b/winsup/cygwin/security.cc
> @@ -1,7 +1,7 @@
>  /* security.cc: NT file access control functions
> 
>     Copyright 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005,
> -   2006, 2007 Red Hat, Inc.
> +   2006, 2007, 2009 Red Hat, Inc.

While you're at it, can you please add the year 2008?  It's missing
accidentally.  Thanks.

> diff --git a/winsup/cygwin/security.h b/winsup/cygwin/security.h
> index 7b09bc0..be0ebd4 100644
> --- a/winsup/cygwin/security.h
> +++ b/winsup/cygwin/security.h
> @@ -350,8 +350,8 @@ LONG __stdcall set_file_sd (HANDLE fh, path_conv &, security_descriptor &sd,
>  			    bool is_chown);
>  bool __stdcall add_access_allowed_ace (PACL acl, int offset, DWORD attributes, PSID sid, size_t &len_add, DWORD inherit);
>  bool __stdcall add_access_denied_ace (PACL acl, int offset, DWORD attributes, PSID sid, size_t &len_add, DWORD inherit);
> -int __stdcall check_file_access (path_conv &, int);
> -int __stdcall check_registry_access (HANDLE, int);
> +int __stdcall check_file_access (path_conv &, int, bool effective = true);
> +int __stdcall check_registry_access (HANDLE, int, bool effective = true);

Can you please drop the default values for the effective flag here
and add the value explicitely where necessary?  AFAICS, that only
affects two calls in spawn.cc which should rather get an explicit
"true".

With these two changes it's ok to check in.


Thanks again,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat



More information about the Cygwin-patches mailing list