[1.7] bugs in faccessat

Christopher Faylor cgf-use-the-mailinglist-please@cygwin.com
Wed Sep 9 15:59:00 GMT 2009


On Wed, Sep 09, 2009 at 02:38:22PM +0100, Dave Korn wrote:
>Christopher Faylor wrote:
>> On Tue, Sep 08, 2009 at 09:16:57PM +0200, Corinna Vinschen wrote:
>>> On Sep  7 16:05, Christopher Faylor wrote:
>>>> On Thu, Sep 03, 2009 at 11:04:38PM +0200, Corinna Vinschen wrote:
>>>>> Thanks for the patches Eric, but, here's a problem.  We still have no
>>>>> copyright assignment in place from you.  The fcntl patch is barely
>>>>> trivial, but the faccessat patch certainly isn't anymore.  Would it
>>>>> be a big problem for you to send the filled out copyright assignemnt form
>>>> >from http://cygwin.com/assign.txt to Red Hat ASAP?  With any luck it
>>>>> will have arrived and will be signed before I'm back from vacation.
>>>> I don't understand why this isn't considered trivial but a basically
>>>> equivalent change to fix other errnos is:
>>>>
>>>> http://cygwin.com/ml/cygwin/2009-09/msg00178.html
>>> It's 2 vs. 30 lines of changes.  That's hardly equivalent.
>> 
>> But each of those changes were obvious and each could have been
>> contributed separately, one for every function.  That would have
>> made them trivial.
>
>There's no simple answer to this, it seems.  On the one hand(*), the
>GNU maintainers' handbook suggests that multiple trivial patches /can/
>over time add up to a substantial contribution(**):

Perhaps it wasn't clear but I'm explaining the criteria that I've used
while running this project both when I worked for Red Hat and
subsequently.

But, regardless, if we were to follow the above advice then presumably
Eric's change in the cygwin list wouldn't be accepted either.

Of course, all of the hundreds of changes that have gone into newlib
really are suspect too.  Why is it ok to change something in one
directory and not another?  I think (and have always thought) that there
is a huge hole in that there are lots of changes in the newlib directory
which have never been assigned.

And, not too long ago (until I changed it) Cygwin was including parts of
libiberty which were definitely not owned by Red Hat.

cgf



More information about the Cygwin-patches mailing list