mkstemps

Christopher Faylor cgf-use-the-mailinglist-please@cygwin.com
Fri Jul 3 15:17:00 GMT 2009


On Fri, Jul 03, 2009 at 03:01:34PM +0200, Corinna Vinschen wrote:
>On Jul  3 06:34, Eric Blake wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> 
>> According to Eric Blake on 7/3/2009 6:31 AM:
>> > With that vote of confidence, here's the patch (the changes to mktemp.cc,
>> > modulo a changed variable name, mirror newlib):
>> > 
>> > 2009-07-03  Eric Blake  <ebb9@byu.net>
>> > 
>> > 	Add fpurge, mkstemps.
>> > 	* cygwin.din (fpurge, mkstemps): New exports.
>> > 	* include/cygwin/version.h (CYGWIN_VERSION_API_MINOR): Bump.
>> > 	* mktemp.cc (_gettemp): Add parameter.
>> > 	(mkstemps): New function.
>> > 	(mkstemp, mkdtemp, mktemp): Adjust clients.
>> 
>> Updated to avoid a compiler warning.
>
>Patch applied.

Is there some reason why we're not just using the newlib version of all
of these functions?  I have stared at the code in mktemp.cc and the only
thing I see that seems to be Cygwin specific is the arc4random function.
Is the security that this provides the only reason not to use newlib?

That is probably a good enough reason right there but I was just
wondering.

cgf



More information about the Cygwin-patches mailing list