sigproc_init() handling CreateThread() failures

Christopher Faylor cgf-no-personal-reply-please@cygwin.com
Thu Jan 5 21:17:00 GMT 2006


On Thu, Jan 05, 2006 at 12:50:47PM -0800, Max Kaehn wrote:
>I notice that no_signals_available() tests my_sendsig using !.
>INVALID_HANDLE_VALUE is -1.  If no_signals_available() evaluates to
>true, that should prevent sig_send() from getting to the
>wait_for_sigthread() when there's no sigthread to wait for.  Here's the
>patch:

But, that is the whole point of setting my_sendsig to INVALID_HANDLE_VALUE.

>2006-01-05  Max Kaehn  <slothman@electric-cloud.com>
>
>	* sigproc.cc (no_signals_available):  test for my_sendsig ==
>	INVALID_HANDLE_VALUE.

This seems like it should work.  Does it have the same effect?

cgf

Index: sigproc.cc
===================================================================
RCS file: /cvs/uberbaum/winsup/cygwin/sigproc.cc,v
retrieving revision 1.271
diff -u -p -r1.271 sigproc.cc
--- sigproc.cc	5 Jan 2006 16:26:22 -0000	1.271
+++ sigproc.cc	5 Jan 2006 21:16:49 -0000
@@ -39,7 +39,7 @@ details. */
 #define WSSC		  60000	// Wait for signal completion
 #define WPSP		  40000	// Wait for proc_subproc mutex
 
-#define no_signals_available(x) (!my_sendsig || ((x) && myself->exitcode & EXITCODE_SET) || &_my_tls == _sig_tls)
+#define no_signals_available(x) (!hwait_sig || ((x) && myself->exitcode & EXITCODE_SET) || &_my_tls == _sig_tls)
 
 #define NPROCS	256
 
@@ -61,6 +61,7 @@ HANDLE NO_COPY signal_arrived;		// Event
 
 HANDLE NO_COPY sigCONT;			// Used to "STOP" a process
 
+Static cygthread *hwait_sig;
 Static HANDLE wait_sig_inited;		// Control synchronization of
 					//  message queue startup
 
@@ -483,9 +484,8 @@ sigproc_init ()
    */
   sync_proc_subproc.init ("sync_proc_subproc");
 
-  my_sendsig = INVALID_HANDLE_VALUE;	// changed later
   sync_startup = NULL;
-  cygthread *hwait_sig = new cygthread (wait_sig, 0, cygself, "sig");
+  hwait_sig = new cygthread (wait_sig, 0, cygself, "sig");
   hwait_sig->zap_h ();
 
   global_sigs[SIGSTOP].sa_flags = SA_RESTART | SA_NODEFER;
@@ -1141,6 +1141,7 @@ wait_sig (VOID *)
 	    }
 	  break;
 	case __SIGEXIT:
+	  hwait_sig = NULL;
 	  sigproc_printf ("saw __SIGEXIT");
 	  break;	/* handle below */
 	default:



More information about the Cygwin-patches mailing list