fix possible segfault creating detached thread (fwd)

Mike Gorse mgorse@alum.wpi.edu
Fri Aug 5 12:32:00 GMT 2005


On Tue, 2 Aug 2005, Corinna Vinschen wrote:

> Can you please review your patch file?  I was unable to apply the patch,
> even when using the -l option:

Pine must be wrapping lines.  I'm resending it as an attachment.

2005-08-05 Michael Gorse <mgorse@alum.wpi.edu>

  * thread.cc (pthread::create(3 args)): Make bool.
  (pthread_null::create): Ditto.
  (pthread::create(4 args)): Check return of inner create rather than
  calling is_good_object().
  * thread.h: Ditto.
-------------- next part --------------
Index: thread.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/thread.cc,v
retrieving revision 1.190
diff -u -p -r1.190 thread.cc
--- thread.cc	6 Jul 2005 20:05:03 -0000	1.190
+++ thread.cc	2 Aug 2005 13:15:04 -0000
@@ -491,13 +491,15 @@ pthread::precreate (pthread_attr *newatt
     magic = 0;
 }
 
-void
+bool
 pthread::create (void *(*func) (void *), pthread_attr *newattr,
 		 void *threadarg)
 {
+  bool retval;
+
   precreate (newattr);
   if (!magic)
-    return;
+    return false;
 
   function = func;
   arg = threadarg;
@@ -517,7 +519,9 @@ pthread::create (void *(*func) (void *),
       while (!cygtls)
 	low_priority_sleep (0);
     }
+  retval = magic;
   mutex.unlock ();
+  return retval;
 }
 
 void
@@ -1993,8 +1997,7 @@ pthread::create (pthread_t *thread, cons
     return EINVAL;
 
   *thread = new pthread ();
-  (*thread)->create (start_routine, attr ? *attr : NULL, arg);
-  if (!is_good_object (thread))
+  if (!(*thread)->create (start_routine, attr ? *attr : NULL, arg))
     {
       delete (*thread);
       *thread = NULL;
@@ -3262,9 +3265,10 @@ pthread_null::~pthread_null ()
 {
 }
 
-void
+bool
 pthread_null::create (void *(*)(void *), pthread_attr *, void *)
 {
+  return true;
 }
 
 void
Index: thread.h
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/thread.h,v
retrieving revision 1.100
diff -u -p -r1.100 thread.h
--- thread.h	5 Jul 2005 03:16:46 -0000	1.100
+++ thread.h	2 Aug 2005 13:15:05 -0000
@@ -380,7 +380,7 @@ public:
   HANDLE cancel_event;
   pthread_t joiner;
 
-  virtual void create (void *(*)(void *), pthread_attr *, void *);
+  virtual bool create (void *(*)(void *), pthread_attr *, void *);
 
   pthread ();
   virtual ~pthread ();
@@ -473,7 +473,7 @@ class pthread_null : public pthread
   /* From pthread These should never get called
   * as the ojbect is not verifyable
   */
-  void create (void *(*)(void *), pthread_attr *, void *);
+  bool create (void *(*)(void *), pthread_attr *, void *);
   void exit (void *value_ptr) __attribute__ ((noreturn));
   int cancel ();
   void testcancel ();


More information about the Cygwin-patches mailing list