[Patch] pinfo.cc: second CreatePipe, not first.

Bas van Gompel cygwin-patches.buzz@bavag.tmfweb.nl
Tue Oct 5 01:49:00 GMT 2004


Hi,

Looking over pinfo.cc, I saw that the debugging-output on
_pinfo::commune_send is awkward. This (trivial again, IMHO)
patch changes that.


Changelog-entry:

2004-10-05  Bas van Gompel  <cygwin-patch.buzz@bavag.tmfweb.nl>

	* pinfo.cc (_pinfo::commune_send): Make debugging output less ambiguous.


--- src/winsup/cygwin/pinfo.cc	12 Sep 2004 03:47:56 -0000	1.120
+++ src/winsup/cygwin/pinfo.cc	4 Oct 2004 23:59:17 -0000
@@ -501,7 +501,7 @@ _pinfo::commune_send (DWORD code, ...)
     }
   if (!CreatePipe (&fromme, &tothem, &sec_all_nih, PIPEBUFSIZE))
     {
-      sigproc_printf ("first CreatePipe failed, %E");
+      sigproc_printf ("second CreatePipe failed, %E");
       __seterrno ();
       goto err;
     }

L8r,

Buzz.
(On this one there was little formatting to botch. :-) )

BTW: Is it as it should be that either PID_INITIALIZING or (both
PID_IN_USE *and* PID_ACTIVE) must be set for proc_can_be_signalled
(sigproc.cc) to return true? (Sorry if this is a stupid question, my
understanding of the signal-code is hazy at best, despite reading
``how-signals-work.txt'' and most of the source-code.)
-- 
  ) |  | ---/ ---/  Yes, this | This message consists of true | I do not
--  |  |   /    /   really is |   and false bits entirely.    | mail for
  ) |  |  /    /    a 72 by 4 +-------------------------------+ any1 but
--  \--| /--- /---  .sigfile. |   |perl -pe "s.u(z)\1.as."    | me. 4^r



More information about the Cygwin-patches mailing list