[PATCH]: 2. Thread safe stdio update

Thomas Pfaff tpfaff@gmx.net
Fri Jan 23 11:03:00 GMT 2004


Corinna Vinschen wrote:
> On Jan 22 21:48, Thomas Pfaff wrote:
> 
>>This is an update of my previous patch. It adds support for newlibs 
>>__LOCK_INIT macro.
>>
>>Thomas
>>
>>2004-01-22 Thomas Pfaff <tpfaff@gmx.net>
>>
>>	* include/sys/_types.h: New file.
> 
> 
> I'm not quite sure if that's the way to go.  I'm wondering if we
> shouldn't keep newlib's _types.h and change it like this:
> 
>   #ifdef __CYGWIN__
>   #include <cygwin/_types.h>
>   #endif
> 
>   #ifndef __CYGWIN__
>   typedef int _flock_t;
>   #endif
> 
> Then we can create a cygwin/_types.h with the correct _flock_t definition.
> IMHO that's cleaner than just overloading newlib's _types.h.
> 

You may be right.

I just followed the way it was done in newlibs linux support where a 
modified _types.h is in newlib/libc/sys/linux/sys (and it was the 
easiest way for me to test it).

Will you make this change in newlibs _types.h ?

Thomas



More information about the Cygwin-patches mailing list