[PATCH] Change pthread equations
Robert Collins
rbcollins@cygwin.com
Thu Mar 27 19:55:00 GMT 2003
On Thu, 2003-03-27 at 23:52, Thomas Pfaff wrote:
> 2003-03-27 Thomas Pfaff <tpfaff@gmx.net>
>
> * thread.cc: Change 1==foo equations to foo==1 throughout.
Thanks again - please apply.
I don't know if you meant to do this:
- return (pthread_equal ((*mutex)->owner, self)) && 1 ==
(*mutex)->recursion_counter;
+ return ((*mutex)->recursion_counter == 1 && pthread_equal
((*mutex)->owner, self));
But it's actually more than just changing 1==foo to foo==1. If there
where side effects in pthread_equal, the meaning would have changed.
Rob
--
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20030327/834cf680/attachment.sig>
More information about the Cygwin-patches
mailing list