access()

Christopher Faylor cgf@redhat.com
Fri Feb 21 15:32:00 GMT 2003


On Fri, Feb 21, 2003 at 03:31:27PM +0100, Corinna Vinschen wrote:
>On Thu, Feb 20, 2003 at 08:15:34PM -0500, Pierre A. Humblet wrote:
>> However bash already uses access() when AFS is defined. Thus it
>> would be a 1/2 line patch in bash (test.c and findcmd.c) to also
>> use access() for Cygwin. 
>> - #if defined (AFS)
>> + #if defined (AFS) || defined (__CYGWIN__)
>> That would be a significant improvement, IMO. What do you think?
>
>Yes, I'll change that.  Thanks for the hint.
>
>> 2003-02-21  Pierre Humblet  <pierre.humblet@ieee.org>
>> 
>> 	* autoload.cc (AccessCheck): Add.
>> 	(DuplicateToken): Add.
>> 	* security.h (check_file_access): Declare.
>> 	* syscalls.cc (access): Convert path to Windows, check existence
>> 	and readonly attribute. Call check_file_access instead of acl_access.
>> 	* security.cc (check_file_access): Create.
>> 	* sec_acl (acl_access): Delete.
>
>I'm impressed.  Works nice with no more handcrafted messing around
>with ACLs.

If I read Pierre's previous message correctly, it sounds like /bin/test
is now broken.  Was someone going to fix that?

cgf



More information about the Cygwin-patches mailing list