Performance: fhandler_socket and ready_for_read()
Corinna Vinschen
cygwin-patches@cygwin.com
Wed Jul 31 06:20:00 GMT 2002
On Wed, Jul 31, 2002 at 01:28:32PM +0100, Conrad Scott wrote:
> "Corinna Vinschen" <cygwin-patches@cygwin.com> wrote:
> > I agree. Just setting the flag is cleaner than overriding the
> method
> > while the flag is still set to a wrong value, isn't it?
>
> It is, especially now that I look at this in the, umm, early
> afternoon light after a good, umm, night's sleep (tho' no coffee
> or breakfast yet, so no guarantees).
>
> Summarising last night's twisty little thread, this patch just
> sets the NOEINTR flag for sockets if winsock2 is available, which
> should keep us all happy. And it makes the get_r_no_interrupt
> method non-virtual again too. Just in case :-)
Cool. Applied. Sorry but reviewing your other patch will take
a little bit longer. I'd especially like to have Egor's comment
on the security stuff.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.
More information about the Cygwin-patches
mailing list