/proc and /proc/registry

Chris January chris@atomice.net
Tue Feb 26 22:49:00 GMT 2002


> 1) The copyrights still need to be changed.
Done.
> 2) The code formatting still is not correct.
Now piped through indent with a few touch-ups.
> 3) You have a lot of calls to normalize_posix_path.  Is that really
>    necessary?  It seems to be called a lot.  If it is really necessary,
>    I'd prefer that it just be called in dtable::build_fhandler and made
>    the standard "unix_path_name".
Done.
> 4) Could you generate the diff using 'cvs diff -up"
Done. The new files are diff'ed against /dev/null and are appended to the
output of cvs diff.

NB: The ChangeLog has two additions because I found chdir had broken.

Regards
Chris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: proc.patch
Type: application/octet-stream
Size: 44083 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20020226/b6cf65b3/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ChangeLog
Type: application/octet-stream
Size: 1242 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20020226/b6cf65b3/attachment-0001.obj>


More information about the Cygwin-patches mailing list