patch to mkpasswd.c - allows selection of specific user
Mark Bradshaw
bradshaw@staff.crosswalk.com
Tue Oct 9 10:20:00 GMT 2001
Sorry. I threw that in at the last. Thought it might be helpful for the
enduser to get a little feedback for that error. I'll fix it.
> -----Original Message-----
> From: Christopher Faylor [mailto:cgf@redhat.com]
> Sent: Tuesday, November 13, 2001 12:22 AM
> To: cygwin-patches@cygwin.com
> Subject: Re: patch to mkpasswd.c - allows selection of specific user
>
>
> On Tue, Nov 13, 2001 at 04:02:32PM +1100, Mathew Boorman wrote:
> >Darn, now I'm told about Marks patch!
> >Anyway, onward...
> >
> >Mark Bradshaw:
> >
> >>@@ -135,6 +145,7 @@ enum_users (LPWSTR servername, int print
> >> default:
> >> fprintf (stderr, "NetUserEnum() failed with %ld\n", rc);
> >>+ if ( rc == 2221 ) printf("That user doesn't appear to
> exist.\n");
> >
> >The appropriate error codes are in <lmerr.h> around, I noted
> some were
> >slightly different in name though. I believe this message
> should go to
> >stderr anyway, otherwise you would end up with a polluted
> /etc/passwd
> >file.
>
> Oops. This points out a couple of problems that I didn't
> notice before.
>
> 1) Never use a raw number like the above, as Mathew has said.
>
> 2) This is not the correct format for an if statement. You
> aren't adhering
> to the GNU formatting conventions. Please use the
> formatting of the
> code that you are patching. This is good advice for
> whatever project
> you are on.
>
> Thanks,
> cgf
>
More information about the Cygwin-patches
mailing list