known issues with current dll
Christopher Faylor
cgf@redhat.com
Sun Mar 18 09:20:00 GMT 2001
On Sun, Mar 18, 2001 at 06:09:02PM +0300, Egor Duda wrote:
>Hi!
>
>Saturday, 17 March, 2001 Christopher Faylor cgf@redhat.com wrote:
>
>CF> On Sat, Mar 17, 2001 at 04:05:36PM +0300, Egor Duda wrote:
>>>to solve ctrl-D problem i see 2 ways -- either return to the old
>>>scheme, when master sends dummy buffer to slave via pipe on eof, or
>>>tweak ready_to_read stuff for fhandler_tty_slave, so it will react
>>>when input_available_event is signalled, not when pipe handle does.
>>>currently, i'm trying to do the latter.
>
>CF> I think that the latter makes sense.
>
>CF> Maybe it's time to separate the pipe stuff from the tty stuff in select.cc
>
>this patch fixes ctrl-d problem. this also make cygwin discard
>contents of input buffer in canonical mode when user type VINTR, VSTOP
>or VSUSP character.
Looks perfect, with one comment:
@@ -762,4 +762,6 @@ public:
off_t lseek (off_t, int) { return 0; }
+ virtual select_record *select_read (select_record *s);
+ int ready_for_read (int fd, DWORD howlong, int ignra);
};
Is there any reason for this method to be virtual?
Otherwise, please check this in. It will be interesting to see if this
fixes Earnie's problem.
cgf
More information about the Cygwin-patches
mailing list