tty.cc and fhandler/tty.cc

[Takashi Yano]

On Tue, 22 Nov 2022 10:36:28 +0100
Corinna Vinschen wrote:
> On Nov 22 17:31, Takashi Yano wrote:
> > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class,
> > so, what about renaming fhandler/tty.cc to fhandler/pty.cc?
> 
> Maybe we could split it up.  The extern functions could go into
> syscalls.cc and the tty classes could go into fhandler/termios.cc,
> perhaps.  There are already two tty_min methods in that file.
> 
> What do you think?

It looks good alternative.

On Tue, 22 Nov 2022 10:50:46 +0100
Corinna Vinschen wrote:
> If we don't split, maybe something like tty_helper.cc would be more
> feasible?  tty.cc mainly implements the tty/tty_min classes and at least
> the latter is used for consoles, too.  Pty.cc might be a bit misleading

Well, I meant
winsup/cygwin/tty.cc
and
winsup/cygwin/fhandler/pty.cc
.

Not
winsup/cygwin/pty.cc
and
winsup/cygwin/fhandler/tty.cc

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>