tty.cc and fhandler/tty.cc

[Corinna Vinschen]

On Nov 22 10:36, Corinna Vinschen wrote:
> On Nov 22 17:31, Takashi Yano wrote:
> > Current cygwin git master has two tty.cc, one is winsup/cygwin/tty.cc
> > and the other is winsup/cygwin/fhandler/tty.cc (it was originally
> > fhandler_tty.cc). This is somewhat confusing.
> > 
> > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class,
> > so, what about renaming fhandler/tty.cc to fhandler/pty.cc?
> 
> Maybe we could split it up.  The extern functions could go into
> syscalls.cc and the tty classes could go into fhandler/termios.cc,
> perhaps.  There are already two tty_min methods in that file.

If we don't split, maybe something like tty_helper.cc would be more
feasible?  tty.cc mainly implements the tty/tty_min classes and at least
the latter is used for consoles, too.  Pty.cc might be a bit misleading


Corinna