Performance regression in cygwin 3.4.0

Takashi Yano takashi.yano@nifty.ne.jp
Fri Dec 9 00:48:14 GMT 2022


On Thu, 8 Dec 2022 15:56:43 -0500
Ken Brown wrote:
> On 12/8/2022 10:30 AM, Corinna Vinschen wrote:
> > Hi Takashi,
> > As for the code, I have just one nit.  Don't use GetTickCount.  Use
> > GetTickCount64().  I just noticed you're using it in tty::wait_fwd as
> > well.  Please use GetTickCount64() there, too.  This way you can
> > get rid of the overflow handling.
> > 
> > Ken?  Any more input?
> 
> LGTM.

Thanks for reviewing. I will submit a revised patch
to cygwin-patches@cygwin.com.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


More information about the Cygwin-developers mailing list