cygrunsrv + sshd + rsync = 20 times too slow -- throttled?
Takashi Yano
takashi.yano@nifty.ne.jp
Tue Sep 21 15:36:14 GMT 2021
On Tue, 21 Sep 2021 09:31:45 -0400
Ken Brown wrote:
> On 9/21/2021 4:30 AM, Takashi Yano wrote:
> > On Mon, 20 Sep 2021 17:39:54 -0400
> > Ken Brown wrote:
> >> I'll push it tomorrow unless you find something that needs to be changed before
> >> then.
> >
> > * Add name check when cached information is used.
> > * Confirm Name.Buffer returned by NtQueryObject() is not NULL.
> > * Add error check for HeapAlloc().
>
> Still looks good. One small question: Is there a reason you cache the pipe
> name's pid and id but not the key? Wouldn't you get a more complete name check
> by also using the key?
key always has same value, so I did not think it is necessary to
be checked. However, if someone has multiple cygwin installations,
pipe name may be confilict without keys.
Therefore, I have added key check as well as pid and id.
Thanks for the advice.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v6-0001-Cygwin-pipe-Introduce-temprary-query_hdl.patch
Type: application/octet-stream
Size: 10365 bytes
Desc: not available
URL: <https://cygwin.com/pipermail/cygwin-developers/attachments/20210922/2e45698a/attachment.obj>
More information about the Cygwin-developers
mailing list