cygrunsrv + sshd + rsync = 20 times too slow -- throttled?

Corinna Vinschen corinna-cygwin@cygwin.com
Wed Sep 8 11:55:41 GMT 2021


On Sep  8 20:32, Takashi Yano wrote:
> Hi Corinna,
> 
> On Thu, 2 Sep 2021 21:35:21 +0200
> Corinna Vinschen wrote:
> > It's getting too late again.  I drop off for tonight, but I attached
> > my POC code I have so far.  It also adds the snippets from my previous
> > patch which fixes stuff Takashi found during testing.
> > [...]
> > Patch relativ to topic/pipe attached.  Would you both mind to take a
> > scrutinizing look?
> 
> Sorry for replying to old post.
> 
> As for this patch, read_mtx was introduced. This handle is initialized
> only for read pipe. However, this seems to be NULL even without
> initialization in write pipe. I wonder why initializing read_mtx in
> the constructor is not necessary.
> 
> How do you guarantee that read_mtx is NULL on the write pipe?

fhandlers are always calloc'ed on the cygheap, so you don't have
to initialize anything to NULL.  It doesn't hurt, of course, but
it's certainly not required.


Corinna


More information about the Cygwin-developers mailing list