3.3.0: Possible regression in cygwin DLL (Win10); fixed in snapshot
Mon Nov 8 09:46:53 GMT 2021
On Nov 8 17:23, Takashi Yano wrote:
> On Sun, 7 Nov 2021 17:20:46 -0500
> Ken Brown wrote:
> > In the meantime I found the commit that changed the default from byte mode to
> > message mode:
> > commit 31d2bedc585420092eb53895c5f5646651f13215
> > Author: Christopher Faylor <email@example.com>
> > Date: Sun Oct 23 19:01:47 2011 +0000
> > * fhandler_tty.cc (fhandler_pty_slave::read): Use consistent way for testing
> > ReadFile return.
> > * pipe.cc (fhandler_pipe::create_selectable): Open the write side of the pipe
> > in message-mode to force writing as "chunks". Explain why.
> > [...]
> > I also found discussion on the mailing list on the same day as this commit in
> > which cgf referred to fixing a bug (that *I* reported, coincidentally):
> > https://cygwin.com/pipermail/cygwin/2011-October/197953.html
> > I'll try to test more thoroughly tomorrow, but a quick test seems to show that
> > the STC I submitted in connection with that bug report now succeeds even with
> > CYGWIN=pipe_byte.
> The STC attached to that post is checking pty behaviour. Currently,
> the named pipe for pty is always configured as message type regardless
> of CYGWIN=pipe_byte.
Ok, I guess we proceed with the patch Takashi sent to -patches for 3.3.2.
For the master branch, if you like, go ahead and switch to byte mode and
sync IO. Or we can do that on the topic/pipe branch and merge into master
at one point, that worked nicely the last time, too.
More information about the Cygwin-developers