New implementation of pseudo console support (experimental)

Takashi Yano takashi.yano@nifty.ne.jp
Sat Jul 18 05:07:33 GMT 2020


Hi Ken,

Thanks for testing.

On Fri, 17 Jul 2020 08:52:15 -0400
Ken Brown via Cygwin-developers <cygwin-developers@cygwin.com> wrote:

> On 7/17/2020 7:19 AM, Corinna Vinschen wrote:
> > Hi Takashi,
> > 
> > On Jul  1 20:47, Takashi Yano via Cygwin-developers wrote:
> >> On Fri, 29 May 2020 00:40:24 +0900
> >> Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> >>> On Tue, 26 May 2020 10:09:55 +0900
> >>> Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> >>>> On Mon, 25 May 2020 19:53:32 +0900
> >>>> Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> >>>>> On Tue, 19 May 2020 22:40:18 +0900
> >>>>> Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> >>>>>> On Sat, 16 May 2020 16:47:35 +0900
> >>>>>> Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> >>>>>>> On Sat, 16 May 2020 09:29:56 +0900
> >>>>>>> Takashi Yano via Cygwin-developers <cygwin-developers@cygwin.com> wrote:
> >>>>>>>> Fix a small bug caused when stdio is redirected to another pty.
> >>>>>>>
> >>>>>>> Fix another bug caused when stdio is redirected to another pty.
> >>>>>>
> >>>>>> Revise the patch to fit the current git head.
> >>>>>
> >>>>> Revise the patch again to fit the current git head.
> >>>>
> >>>> Make app, which reads stdin, work under gdb.
> >>>
> >>> * Prevent ResizePseudoConsole() calls unless the pty is resized.
> >>> * Revise the patch to fit the current git head.
> >>
> >> Revise the patch to fit the current git head.
> > 
> > are you satisfied with the code?  If you want to merge it,
> > I'd bump Cygwin to 3.2.
> 
> FWIW, I just installed this patch locally and am seeing noticeable speed 
> improvements.  For example, here's the result of running 'make -j13 check' in 
> the info subdirectory of the texinfo source directory.  [I chose this test 
> because it uses both FIFOs and ptys.]
> 
> Without the patch:
> 
> $ time make -j13 check
> [...]
> real    0m20.705s
> user    0m18.639s
> sys     0m40.187s
> 
> With the patch:
> 
> $ time make -j13 check
> [...]
> real    0m9.332s
> user    0m14.153s
> sys     0m30.235s

This is the advantage 1) in my first post.
Advantage:
1) No performance degradation in pty output for cygwin process.
    https://sourceware.org/pipermail/cygwin/2020-February/243651.html

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


More information about the Cygwin-developers mailing list