trailing dots and spaces on Samba

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Apr 29 15:05:00 GMT 2010


On Apr 29 10:18, Christopher Faylor wrote:
> On Wed, Apr 28, 2010 at 05:34:32PM +0200, Corinna Vinschen wrote:
> >On Apr 28 16:39, Corinna Vinschen wrote:
> >> On Apr 28 10:01, Christopher Faylor wrote:
> >> > On Wed, Apr 28, 2010 at 10:15:56AM +0200, Corinna Vinschen wrote:
> >> > >So I was wondering if we shouldn't add more filesystem-specific settings
> >> > >to the mount options so a user can help herself instead of having to
> >> > >wait for us to fix Cygwin.  After all, on Linux every filesystem invents
> >> > >its own mount options, too, as it goes along.
> >> > 
> >> > This was the conclusion that I came to as I was reading your description.
> >> > If we're going to do that we might want to think about a better way of
> >> > recognizing the options than just doing a bunch of strcmp's.
> >> 
> >> I agree, read_flags could really use bsearch instead of that
> >> hand-crafted loop.
> >
> >And it might be a good idea to add a new cygwin_internal type which
> >exports the read_flags functionality.  In other words, which converts an
> >option string into the numerical option value.  The point is that
> >`mount' would not need to be changed anymore, just because we add or
> >remove a mount option.
> 
> I saw that you implemented this but I meant to ask "How does linux do this?"
> It must have some way to communicate mount strings from the kernel/kernel-modules
> to mount(8).

I just had a look into mount from util-linux.  No surprise it's more
complicated than our mount, but, surprise, it does not communicate
valid options with the kernel.  There are two types of options.

Those which are known to mount itself, for which it has its own table
just like our struct opt.

And those it doesn't know which it puts on the command line when starting
one of the mount helpers in /sbin, like mount.cifs, or mount.nfs.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat



More information about the Cygwin-developers mailing list