shared_info::heap_chunk* questions (and potential patch)
Jason Tishler
jason@tishler.net
Fri Jan 31 14:06:00 GMT 2003
While trying to increase the Cygwin heap size (to see if this would
allow PostgreSQL's PL/Tcl to work properly), I noticed the following:
1. The shared_info::heap_chunk value seems to be uninitialized so that
shared_info::heap_chunk_size() always returns without examining the
registry for user settings.
2. There appears to be a "yank and put" typo when querying the HKLM
value.
See attached for the details. Am I missing something?
Thanks,
Jason
--
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6
-------------- next part --------------
Index: shared.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/shared.cc,v
retrieving revision 1.64
diff -u -p -r1.64 shared.cc
--- shared.cc 2 Nov 2002 03:31:15 -0000 1.64
+++ shared.cc 31 Jan 2003 13:37:00 -0000
@@ -146,6 +146,8 @@ open_shared (const char *name, int n, HA
void
shared_info::initialize ()
{
+ heap_chunk = 0;
+
if (version)
{
if (version != SHARED_VERSION_MAGIC)
@@ -245,7 +247,7 @@ shared_info::heap_chunk_size ()
reg_key r1 (HKEY_LOCAL_MACHINE, KEY_READ, "SOFTWARE",
CYGWIN_INFO_CYGNUS_REGISTRY_NAME,
CYGWIN_INFO_CYGWIN_REGISTRY_NAME, NULL);
- heap_chunk = reg.get_int ("heap_chunk_in_mb", 384);
+ heap_chunk = r1.get_int ("heap_chunk_in_mb", 384);
}
if (heap_chunk < 4)
More information about the Cygwin-developers
mailing list