[PATCH] change to thread.cc -- need feedback
Robert Collins
rbcollins@cygwin.com
Mon Sep 30 13:44:00 GMT 2002
On Tue, 2002-10-01 at 01:12, Christopher Faylor wrote:
> I've changed the static declarations in thread.cc to use
> NO_COPY and things seem to be working better in my build.
Ah yes, good thing.
> In doing this, I noticed that a CreateEvent and a CreateMutex were using
> a default argument 1 (security attributes).
>
> I changed these to an explicit "no inherit" but I'm not 100% sure
> that this is the right thing to do in all cases.
The MS Doco for createMutex says that a default argument results in a
non inheritable mutex. so in theory, it's the right thing.
> Could someone who is familiar with the code (Robert?, Thomas?) look
> at the patch below and, if I got it wrong, fix this so that the
> handles will be properly inherited, if required?
Please commit this.
Rob
--
---
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.
---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20020930/0649901f/attachment.sig>
More information about the Cygwin-developers
mailing list