Recent change to init.cc for thread detach looks wrong?

[Robert Collins]

On Fri, 2002-09-20 at 17:42, Thomas Pfaff wrote:
> 
> 
> On Fri, 20 Sep 2002, Robert Collins wrote:
> 
> > On Fri, 2002-09-20 at 15:32, Christopher Faylor wrote:
> > > Robert,
> > > Your recent change:
> > > 2002-09-11  Robert Collins  <rbtcollins@hotmail.com>
> > >
> > >         * init.cc (dll_entry): On thread detach, if the thread hasn't
> > >         exit()ed, do so.
> > >
> > > doesn't look right.  The code invokes pthread::exit which can block
> > > waiting on a mutex, it seems.
> >
> > Ok, will correct this weekend.
> >
> 
> You may have a look at my pthread patch part 4 that shows how i
> have implemented cleanup after thread termination.

Ok, so this effectively calls pthread::~pthread, which closes the win32
objects, but does not set exit values etc.

Hmm, I need to look more closely.

lets try and get your patches in, rather than reinvent something.

Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-developers/attachments/20020920/e667ddb1/attachment.sig>