miscfuncs.cc won't compile with --enable-debugging

Christopher Faylor cgf@redhat.com
Mon Oct 22 14:20:00 GMT 2001


On Mon, Oct 22, 2001 at 04:28:04PM -0400, Jonathan Kamens wrote:
>Corinna checked a change in today which break miscfuncs.cc when
>--enable-debugging is used.  Here's a patch:

Thanks but I think that it makes sense for set_errno to always do the
same thing regardless of whether DEBUGGING is enabled.  I checked in
a patch to do this.

cgf

>Index: miscfuncs.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/miscfuncs.cc,v
>retrieving revision 1.7
>diff -u -r1.7 miscfuncs.cc
>--- miscfuncs.cc	2001/10/22 11:31:39	1.7
>+++ miscfuncs.cc	2001/10/22 20:26:55
>@@ -158,7 +158,7 @@
> __check_invalid_read_ptr_errno (const void *s, unsigned sz)
> {
>   if (!s || IsBadReadPtr ((void *) s, sz))
>-    return set_errno (EFAULT);
>+    set_errno (EFAULT);
> 
>-  return 0;
>+  return get_errno();
> }



More information about the Cygwin-developers mailing list