unknown commands in \033[xx;yy;zzm aren't ignored

[Egor Duda]

Hi!

Thursday, 15 February, 2001 Christopher Faylor cgf@redhat.com wrote:

>>however. the reason is this fragment
>>
>>    default:
>>      fg = default_color & (FOREGROUND_BLUE | FOREGROUND_GREEN |
>>                            FOREGROUND_RED);
>>      bg = default_color & (BACKGROUND_BLUE | BACKGROUND_GREEN |
>>                            BACKGROUND_RED | BACKGROUND_INTENSITY);
>>      bold = default_color & FOREGROUND_INTENSITY;
>>      break;
>>
>>in fhandler_console::char_command. shouldn't this code be eliminated?

CF> Are you saying that the 666 is causing incorrect behavior?

yes.  when  we  scan  \033[1;666m  command,  we  first  set  fg and bg
variables   to  correct  "bold"  values, an then we see 666 and quoted
code reset fg and bg to the fixed values based on default_color.

CF>  If  so,  I  think   I  agree.   Why  should cygwin be setting any
CF> defaults at all if it doesn't understand the numeric code?

i'll submit a patch.

Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19