PATCH [was Re: difficult problem with symbolic link handling]

Christopher Faylor cgf@redhat.com
Mon Apr 30 09:54:00 GMT 2001


On Mon, Apr 30, 2001 at 02:24:43PM +0200, Corinna Vinschen wrote:
>On Mon, Apr 30, 2001 at 11:55:25AM +0200, Corinna Vinschen wrote:
>> Further behaviour is related to "check_case=relaxed".
>> I think that's actually the same bug but just for
>> clearness I send both problems:
>> 
>> - TAB-completion doesn't work correctly. Example
>> 	$ cd src/openssh/<TAB>
>>   shows the contents of src/, not of src/openssh/.
>> 
>> - chdir doesn't work correctly.
>>   Example bash:
>> 	$ cd src/openssh/src
>> 	$ pwd
>> 	/home/corinna/src/openssh/src
>> 	$ ls
>> 	<Output for ~/src, not for ~/src/openssh/src>
>>   Example tcsh:
>>   	$ cd src/openssh/src
>> 	$ pwd
>> 	/src
>> 
>> 	$ cd src
>> 	$ cd openssh
>> 	$ cd src
>> 	$ pwd
>> 	/src/openssh/src
>> 	$ cd ..
>> 	$ pwd
>> 	/src
>
>That problem can be solved by the following patch:
>
>	* path.cc (path_conv::check): Update tail to actual pinched off
>	path tail.
>
>Index: path.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/path.cc,v
>retrieving revision 1.130
>diff -u -p -r1.130 path.cc
>--- path.cc     2001/04/30 01:46:31     1.130
>+++ path.cc     2001/04/30 12:22:10
>@@ -559,7 +559,7 @@ path_conv::check (const char *src, unsig
>       else
>        {
>          *headptr++ = '/';
>-	  strcpy (headptr, tail);
>+	  strcpy (headptr, ++tail);
>        }
> 
>       src = tmp_buf;
>

Thanks.  This was one of a couple of problems.

One large problem was that I'd already fixed some things in my local sandbox
and neglected to check things in.

I've checked in a change which rectifies the problems that you reported, for
me at least.

There are still some relative path issues from Kazuhiro that I'm mulling
over, though.

cgf



More information about the Cygwin-developers mailing list