[newlib-cygwin/cygwin-3_5-branch] Cygwin: SetThreadName: avoid spurious debug message

[Corinna Vinschen]

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=2196f93fdadccebd71792ad190cfdf054d635994

commit 2196f93fdadccebd71792ad190cfdf054d635994
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Wed Nov 20 16:21:03 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Wed Nov 20 17:12:09 2024 +0100

    Cygwin: SetThreadName: avoid spurious debug message
    
    The following debug message occassionally shows up in strace output:
    
      SetThreadName: SetThreadDescription() failed. 00000000 10000000
    
    The HRESULT of 0x10000000 is not an error, rather the set bit just
    indicates that this HRESULT has been created from an NTSTATUS value.
    
    Use the IS_ERROR() macro instead of just checking for S_OK.
    
    Fixes: d4689b99c686 ("Cygwin: Set threadnames with SetThreadDescription()")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
    (cherry picked from commit 21a2c9db6952954608cdf92638b411b15e7606c6)

Diff:
---
 winsup/cygwin/miscfuncs.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/miscfuncs.cc b/winsup/cygwin/miscfuncs.cc
index 767384faa9ae..4220f6275785 100644
--- a/winsup/cygwin/miscfuncs.cc
+++ b/winsup/cygwin/miscfuncs.cc
@@ -353,7 +353,7 @@ SetThreadName (DWORD dwThreadID, const char* threadName)
       WCHAR buf[bufsize];
       bufsize = MultiByteToWideChar (CP_UTF8, 0, threadName, -1, buf, bufsize);
       HRESULT hr = SetThreadDescription (hThread, buf);
-      if (hr != S_OK)
+      if (IS_ERROR (hr))
 	{
 	  debug_printf ("SetThreadDescription() failed. %08x %08x\n",
 			GetLastError (), hr);