[newlib-cygwin] Cygwin: disable high-entropy VA for ldh

Takashi Yano tyan0@sourceware.org
Sun Jun 2 20:34:04 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=10b921681108b333d17d8438a45afe6fbc1169dd

commit 10b921681108b333d17d8438a45afe6fbc1169dd
Author: Jeremy Drake via Cygwin-patches <cygwin-patches@cygwin.com>
Date:   Tue May 28 10:19:22 2024 -0700

    Cygwin: disable high-entropy VA for ldh
    
    If ldd is run against a DLL which links to the Cygwin DLL, ldh will end
    up loading the Cygwin DLL dynamically, much like cygcheck or strace.
    
    Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
    Fixes: 60675f1a7eb2 ("Cygwin: decouple shared mem regions from Cygwin DLL")
    Reviewed-by: Ken Brown <kbrown@cornell.edu>, Takashi Yano <takashi.yano@nifty.ne.jp>
    Signed-off-by: Jeremy Drake <cygwin@jdrake.com>

Diff:
---
 winsup/cygwin/release/3.5.4    | 3 +++
 winsup/utils/mingw/Makefile.am | 1 +
 2 files changed, 4 insertions(+)

diff --git a/winsup/cygwin/release/3.5.4 b/winsup/cygwin/release/3.5.4
index 257e012fc..2a5f2b1bd 100644
--- a/winsup/cygwin/release/3.5.4
+++ b/winsup/cygwin/release/3.5.4
@@ -12,3 +12,6 @@ Fixes:
 - Fix regression of pthread::once() introduced in 3.5.0 (i.e., the race
   issue regarding destroying mutex).
   Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255987.html
+
+- Fix a problem that ldd command against cygwin DLLs sometimes hangs.
+  Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
diff --git a/winsup/utils/mingw/Makefile.am b/winsup/utils/mingw/Makefile.am
index d9557d8b5..7f7317ae1 100644
--- a/winsup/utils/mingw/Makefile.am
+++ b/winsup/utils/mingw/Makefile.am
@@ -38,6 +38,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll
 cygwin_console_helper_SOURCES = cygwin-console-helper.cc
 
 ldh_SOURCES = ldh.cc
+ldh_LDFLAGS = ${AM_LDFLAGS} -Wl,--disable-high-entropy-va
 
 strace_SOURCES = \
 	path.cc \


More information about the Cygwin-cvs mailing list