[newlib-cygwin/main] Cygwin: CW_CMDLINE_ALLOC: fix a pontentially undefined return value

Corinna Vinschen corinna@sourceware.org
Thu Feb 1 12:34:59 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=92b7ba4bb8ac2218bc376d883dc7944a4f23d66b

commit 92b7ba4bb8ac2218bc376d883dc7944a4f23d66b
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Thu Feb 1 13:34:52 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Thu Feb 1 13:34:52 2024 +0100

    Cygwin: CW_CMDLINE_ALLOC: fix a pontentially undefined return value
    
    cmdline has to be initialized, otherwise the return value is
    undefined in case generating the command line fails.
    
    Fixes: 732afede9358 ("Cygwin: redefine CW_CMDLINE to CW_CMDLINE_ALLOC")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/external.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/external.cc b/winsup/cygwin/external.cc
index 555422b83ece..6dfd11c44470 100644
--- a/winsup/cygwin/external.cc
+++ b/winsup/cygwin/external.cc
@@ -349,7 +349,7 @@ cygwin_internal (cygwin_getinfo_types t, ...)
 	{
 	  size_t n;
 	  char *cmdline_cheap;
-	  char *cmdline;
+	  char *cmdline = NULL;
 
 	  pid_t pid = va_arg (arg, pid_t);
 	  pinfo p (pid);


More information about the Cygwin-cvs mailing list