[newlib-cygwin] Cygwin: pipes: always close read side pipe handle in error case

Corinna Vinschen corinna@sourceware.org
Tue Sep 14 15:05:59 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b12cf6b3cf1557a73b899f8064389966e52d5949

commit b12cf6b3cf1557a73b899f8064389966e52d5949
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Fri Sep 3 10:25:29 2021 +0200

    Cygwin: pipes: always close read side pipe handle in error case
    
    Add missing CloseHandle.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler_pipe.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index 85ab3cf55..14f28f02c 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -608,6 +608,7 @@ fhandler_pipe::create (fhandler_pipe *fhs[2], unsigned psize, int mode)
   else if ((fhs[1] = (fhandler_pipe *) build_fh_dev (*pipew_dev)) == NULL)
     {
       delete fhs[0];
+      CloseHandle (r);
       CloseHandle (w);
     }
   else


More information about the Cygwin-cvs mailing list