[newlib-cygwin] Cygwin: FIFO: fstatvfs: use our handle if O_PATH is set

Ken Brown kbrown@sourceware.org
Tue Jan 28 19:06:00 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=13d75fce48436e4f15bf97b4d2145078888994b0

commit 13d75fce48436e4f15bf97b4d2145078888994b0
Author: Ken Brown <kbrown@cornell.edu>
Date:   Fri Jan 24 15:09:03 2020 -0500

    Cygwin: FIFO: fstatvfs: use our handle if O_PATH is set
    
    If O_PATH is set, then the fhandler_fifo object has a handle that can
    be used for getting the statvfs information.  Use it by calling
    fhandler_base::fstatvfs_by_handle.  Before this change,
    fhandler_disk_file::fstatfvs was called on a new fhandler_disk_file
    object, which would then have to be opened.

Diff:
---
 winsup/cygwin/fhandler_fifo.cc | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc
index a338f12..ef568f6 100644
--- a/winsup/cygwin/fhandler_fifo.cc
+++ b/winsup/cygwin/fhandler_fifo.cc
@@ -906,6 +906,14 @@ errout:
 int __reg2
 fhandler_fifo::fstatvfs (struct statvfs *sfs)
 {
+  if (get_flags () & O_PATH)
+    /* We already have a handle. */
+    {
+      HANDLE h = get_handle ();
+      if (h)
+	return fstatvfs_by_handle (h, sfs);
+    }
+
   fhandler_disk_file fh (pc);
   fh.get_device () = FH_FS;
   return fh.fstatvfs (sfs);



More information about the Cygwin-cvs mailing list