[newlib-cygwin] Cygwin: console: Fix deadlock at calling fork().

Corinna Vinschen corinna@sourceware.org
Mon Aug 12 15:14:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=92e2c1ad9de2d140374bf789b2eb6142b3297120

commit 92e2c1ad9de2d140374bf789b2eb6142b3297120
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Mon Aug 12 22:46:23 2019 +0900

    Cygwin: console: Fix deadlock at calling fork().
    
    - Calling fork() on console occasionally falls into deadlock. The reason
      is not clear, however, this patch fixes this problem anyway.

Diff:
---
 winsup/cygwin/fhandler_console.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index e3656a3..df28c7f 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -168,8 +168,12 @@ fhandler_console::set_unit ()
       if (created)
 	con.owner = getpid ();
     }
-  if (!created && shared_console_info && kill (con.owner, 0) == -1)
-    con.owner = getpid ();
+  if (!created && shared_console_info)
+    {
+      pinfo p (con.owner);
+      if (!p)
+	con.owner = getpid ();
+    }
 
   dev ().parse (devset);
   if (devset != FH_ERROR)



More information about the Cygwin-cvs mailing list