[newlib-cygwin] Cygwin: FIFO: slightly change the use of write_ready

Ken Brown kbrown@sourceware.org
Sun Jun 23 17:10:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=23570916173c9f16213f1a524ddc96878b4c9d80

commit 23570916173c9f16213f1a524ddc96878b4c9d80
Author: Ken Brown <kbrown@cornell.edu>
Date:   Wed Jun 19 11:14:37 2019 -0400

    Cygwin: FIFO: slightly change the use of write_ready
    
    Make it a manual reset event.  It's only used once to allow a reader
    to open, and there's no reason to ever reset it.  Defensively set it
    when a client connection is recorded, even though it should be set by
    the writer that connected.

Diff:
---
 winsup/cygwin/fhandler_fifo.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc
index a060cb3..e0af54b 100644
--- a/winsup/cygwin/fhandler_fifo.cc
+++ b/winsup/cygwin/fhandler_fifo.cc
@@ -298,6 +298,7 @@ fhandler_fifo::listen_client ()
 void
 fhandler_fifo::record_connection (fifo_client_handler& fc)
 {
+  SetEvent (write_ready);
   fc.state = fc_connected;
   nconnected++;
   fc.fh->set_nonblocking (true);
@@ -489,7 +490,7 @@ fhandler_fifo::open (int flags, mode_t)
       goto out;
     }
   npbuf[0] = 'w';
-  if (!(write_ready = CreateEvent (sa_buf, false, false, npbuf)))
+  if (!(write_ready = CreateEvent (sa_buf, true, false, npbuf)))
     {
       debug_printf ("CreateEvent for %s failed, %E", npbuf);
       res = error_set_errno;



More information about the Cygwin-cvs mailing list