[newlib-cygwin] Revert "Cygwin: passwd/group: allow specifying "." as local computername"

Corinna Vinschen corinna@sourceware.org
Mon Feb 18 09:56:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=9883959f083d13ce9991d2162fcf5fee1613478d

commit 9883959f083d13ce9991d2162fcf5fee1613478d
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Feb 18 10:13:35 2019 +0100

    Revert "Cygwin: passwd/group: allow specifying "." as local computername"
    
    This reverts commit 7c34811440be0bf1e749d9f075f54320c706cb4b.
    
    This potentially allows to circumvent OpenSSHs user/group name matching,
    unless the Admin knows to add every local user twice or to use patterns,
    e.g.:
    
      Match user MACHINE+user,.+user
      Match user *+user
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/uinfo.cc | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index 47fe247..53efc21 100644
--- a/winsup/cygwin/uinfo.cc
+++ b/winsup/cygwin/uinfo.cc
@@ -2008,15 +2008,7 @@ pwdgrp::fetch_account_from_windows (fetch_user_arg_t &arg, cyg_ldap *pldap)
       if ((p = wcschr (name, cygheap->pg.nss_separator ()[0])))
 	{
 	  fq_name = true;
-	  /* Convenience: Translate domain name "." to local machine. */
-	  if (p == name + 1 && name[0] == L'.')
-	    {
-	      p = wcpcpy (name, cygheap->dom.account_flat_name ());
-	      *p = L'\\';
-	      sys_mbstowcs (p + 1, UNLEN + 1, arg.name + 2);
-	    }
-	  else
-	    *p = L'\\';
+	  *p = L'\\';
 	}
       sid = csid;
       ret = LookupAccountNameW (NULL, name, sid, &slen, dom, &dlen, &acc_type);



More information about the Cygwin-cvs mailing list