libgit2

[Jon Turney]

On 24/05/2025 19:27, Jeremy Drake via Cygwin-apps wrote:
> On Sat, 24 May 2025, ASSI via Cygwin-apps wrote:
> 
>> Jeremy Drake via Cygwin-apps writes:
>>> I made a little attempt to update libgit2 based on what MSYS2 did, since

Thanks for looking into this.

I'm afraid our process for dealing with drive-up cygport updates is not 
very reliable (since it relies on someone with appropriate privs noting 
the update and applying it), but we should be able to do that in this 
case :)

>>> it is apparently needed for cargo (and it seems like it's getting close to
>>> possible to build cargo for Cygwin).  Unfortunately, it failed to build in
>>> scallywag:
>>> https://github.com/cygwin/scallywag/actions/runs/15219165082/job/42811502993
>>
>> It needs to be compiled with --std=gnu90, not c90 or it triggers a bug
>> in 3.6.1 headers with the setproctitle declaration.
>>
>>> Also, there are some test failures for me locally.
>>
>> CMake generates a wrong untility.sh, replace $(ARGS) with ${ARGS} there.
>> Tests need to be run with admin privileges dropped.
>>
> 
> Thanks for the hints, that got it running on scallywag as it does locally.
> Attaching updated cygport, scallywag run at
> https://github.com/cygwin/scallywag/actions/runs/15229587565/job/42835871879
> 
> 83% tests passed, 2 tests failed out of 12
> Total Test time (real) = 1182.89 sec
> The following tests FAILED:
> 	  1 - offline (Failed)
> 	 12 - util (Failed)
> Errors while running CTest
> 
> Do I need to probably somehow skip the remaining failing tests (they seem
> generally to be related to Cygwin unicode quirks), or just put
> SCALLYWAG="notest" in the cygport?

I think marking as notest (perhaps with a comment memorializing the 
specifcs) is fine.

I notice that the tests pass (with one hang) when I try against the 
current version we have (0.25.1), but due to the ridiculous amount of 
time that has passed, ascribing that to new tests or upstream 
regressions is more work than it should be...